Add resource_profile support #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-wang-dl
force-pushed
the
add-resource-group
branch
from
294254d to
d646e94
Compare
test/test_spark.py
Outdated
Comment on lines
168
to
171
| with parallel_backend('spark', | ||
| num_cpus_per_spark_task=self.num_cpus_per_spark_task, | ||
| num_gpus_per_spark_task=self.num_gpus_per_spark_task) as (ba, _): | ||
| Parallel(n_jobs=5)(delayed(get_spark_context)(i) for i in range(10)) |
There was a problem hiding this comment.
Let's test with num_gpus_per_spark_task different with default value, like:
Suggested change
| with parallel_backend('spark', | |
| num_cpus_per_spark_task=self.num_cpus_per_spark_task, | |
| num_gpus_per_spark_task=self.num_gpus_per_spark_task) as (ba, _): | |
| Parallel(n_jobs=5)(delayed(get_spark_context)(i) for i in range(10)) | |
| with parallel_backend('spark', | |
| num_cpus_per_spark_task=2, | |
| num_gpus_per_spark_task=2) as (ba, _): | |
| Parallel(n_jobs=5)(delayed(get_spark_context)(i) for i in range(10)) |
WeichenXu123
approved these changes
Jun 10, 2024
lu-wang-dl
force-pushed
the
add-resource-group
branch
from
74cf97c to
bceb7b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra param
resource_profileand setup the resource profile if resource profile is supported.